On Wed, Apr 2, 2014 at 7:56 AM, Michal Simek <monstr@xxxxxxxxx> wrote: > On 03/31/2014 10:22 AM, Linus Walleij wrote: >> On Sat, Mar 29, 2014 at 5:44 AM, Harini Katakam >> <harinikatakamlinux@xxxxxxxxx> wrote: >>> On Sat, Mar 29, 2014 at 3:20 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: >>>> On Thu, Mar 27, 2014 at 4:25 PM, Harini Katakam <harinik@xxxxxxxxxx> wrote: >> >>>>> +/* Read/Write access to the GPIO PS registers */ >>>>> +static inline u32 zynq_gpio_readreg(void __iomem *offset) >>>>> +{ >>>>> + return readl_relaxed(offset); >>>>> +} >>>>> + >>>>> +static inline void zynq_gpio_writereg(void __iomem *offset, u32 val) >>>>> +{ >>>>> + writel_relaxed(val, offset); >>>>> +} >>>> >>>> I think this is unnecessary and confusing indirection. >>>> Just use the readl_relaxed/writel_relaxed functions directly in >>>> the code. >>>> >>> >>> This is just to be flexible. >> >> Define exactly what you mean with "flexible" in this context. I >> only see unnecessary overhead and hard-to-read code. > > We have just passed this discussion for watchdog driver > here: https://lkml.org/lkml/2014/4/1/843 > > Are you ok with doing it in this way? No :-) Subsystem maintainers do not necessarily agree on such issues. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html