On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > It would be great to drop the -keys from the compatible, and to > document the bindings > > Looks good otherwise > > Maxime Hi again, So I should just document the "allwinner,sun50i-a64-lradc" string in Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I also have to add the compatible to the driver code then? Just adding the a64 compatible to a dts wouldn't work without that. Thanks, Luca