RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: Add temperature sensor node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Andy Tang
> Sent: Monday, May 27, 2019 3:27 AM
> To: Leo Li <leoyang.li@xxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>;
> moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx>; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; lkml <linux-
> kernel@xxxxxxxxxxxxxxx>
> Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: Add temperature sensor
> node
> 
> Hi Leo,
> 
> > -----Original Message-----
> > From: Li Yang <leoyang.li@xxxxxxx>
> > Sent: 2019年5月25日 6:32
> > To: Andy Tang <andy.tang@xxxxxxx>
> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>;
> > Mark Rutland <mark.rutland@xxxxxxx>; moderated list:ARM/FREESCALE
> IMX
> > / MXC ARM ARCHITECTURE <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>;
> > open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> > <devicetree@xxxxxxxxxxxxxxx>; lkml <linux-kernel@xxxxxxxxxxxxxxx>
> > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: Add temperature sensor
> > node
> >
> > Caution: EXT Email
> >
> > On Thu, May 23, 2019 at 8:30 PM Yuantian Tang <andy.tang@xxxxxxx>
> > wrote:
> > >
> > > Add nxp sa56004 chip node for temperature monitor.
> > >
> > > Signed-off-by: Yuantian Tang <andy.tang@xxxxxxx>
> > > ---
> > >  arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 5 +++++
> > > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 5 +++++
> > >  2 files changed, 10 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > > index b359068d9605..31fd626dd344 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > > @@ -131,6 +131,11 @@
> > >                                 compatible = "atmel,24c512";
> > >                                 reg = <0x57>;
> > >                         };
> > > +
> > > +                       temp@4c {
> >
> > The recommended name for temperature senor in dts spec is
> > temperature-sensor.
> I didn't find the spec for this recommendation. Could you please provide the
> link?

You can find the spec on https://www.devicetree.org/

> I like to update it to temp-sensor though.
> 
> >
> > > +                               compatible = "nxp,sa56004";
> >
> > The binding says the following property is required.  If it is not the
> > case, probably we should update the binding.
> > - vcc-supply: vcc regulator for the supply voltage.
> I will add the vcc-supply to comply this requirement.
> 
> Thanks,
> Andy
> >
> > > +                               reg = <0x4c>;
> > > +                       };
> > >                 };
> > >
> > >                 i2c@5 {
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > > index f9c272fb0738..012b3f8696b7 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > > @@ -119,6 +119,11 @@
> > >                                 compatible = "nxp,pcf2129";
> > >                                 reg = <0x51>;
> > >                         };
> > > +
> > > +                       temp@4c {
> > > +                               compatible = "nxp,sa56004";
> > > +                               reg = <0x4c>;
> > > +                       };
> > >                 };
> > >         };
> > >  };
> > > --
> > > 2.17.1
> > >




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux