On Wed, Apr 9, 2014 at 4:33 PM, Borislav Petkov <bp@xxxxxxxxx> wrote: > On Wed, Apr 09, 2014 at 11:34:31AM +0530, punnaiah choudary kalluri wrote: >> Since it is recommended in Documentation/kernel-doc-nano-HOWTO.txt >> but also said it is low priority and at the discretion of the MAINTAINER of >> that kernel source file >> >> So, if you recommend not use kernel-doc annotation then i will take care >> in next version. > > I don't think there's need for documenting those functions for > kernel-doc - it is an EDAC driver and not some subsystem function with a > lot of users. OK. I just checked at highbank_mc_edac and other drivers found no documentation for static functions. So, is it ok if i remove documentation completely for these static functions ? Thanks, Punnaiah > >> devm_ioremap_resource function will check this condition, so not >> checking for the NULL explicitly > > And it would say > > dev_err(dev, "invalid resource\n"); > > so we'll know what fails, ok. > >> Since the probe returns error, it it that the devm_ framework will >> clean these resources automatically? > > Ah, that's the managed thing, ok. > > Thanks. > > -- > Regards/Gruss, > Boris. > > Sent from a fat crate under my desk. Formatting is fine. > -- > -- > To unsubscribe from this list: send the line "unsubscribe linux-edac" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
