On 21/05/2019 13:56, Leonard Crestez wrote: > On 5/17/2019 8:49 AM, Anson Huang wrote: > >> + root = of_find_node_by_path("/"); >> + >> + np = of_find_compatible_node(NULL, NULL, "fsl,imx-scu"); > > It's possibly not very important for root or FW communication nodes but > you should probably of_node_put those back. Isn't it better/simpler to use of_root? extern struct device_node *of_root; Regards.