Re: [PATCH] ARM: dts: at91: Avoid colliding 'display' node and property names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/05/2019 at 00:56, Rob Herring wrote:
> While properties and child nodes with the same name are valid DT, the
> practice is not encouraged. Furthermore, the collision is problematic for
> YAML encoded DT. Let's just avoid the issue and rename the nodes.
> 
> Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>

Good for me:
Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>

> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Cc: Ludovic Desroches <ludovic.desroches@xxxxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>   arch/arm/boot/dts/at91sam9261ek.dts    | 2 +-
>   arch/arm/boot/dts/at91sam9263ek.dts    | 2 +-
>   arch/arm/boot/dts/at91sam9m10g45ek.dts | 2 +-
>   arch/arm/boot/dts/at91sam9rlek.dts     | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91sam9261ek.dts b/arch/arm/boot/dts/at91sam9261ek.dts
> index f681cd727010..02b116b48c3b 100644
> --- a/arch/arm/boot/dts/at91sam9261ek.dts
> +++ b/arch/arm/boot/dts/at91sam9261ek.dts
> @@ -49,7 +49,7 @@
>   			atmel,power-control-gpio = <&pioA 12 GPIO_ACTIVE_LOW>;
>   			status = "okay";
>   
> -			display0: display {
> +			display0: panel {
>   				bits-per-pixel = <16>;
>   				atmel,lcdcon-backlight;
>   				atmel,dmacon = <0x1>;
> diff --git a/arch/arm/boot/dts/at91sam9263ek.dts b/arch/arm/boot/dts/at91sam9263ek.dts
> index 13d415c22a69..924fe563f6fa 100644
> --- a/arch/arm/boot/dts/at91sam9263ek.dts
> +++ b/arch/arm/boot/dts/at91sam9263ek.dts
> @@ -111,7 +111,7 @@
>   			display = <&display0>;
>   			status = "okay";
>   
> -			display0: display {
> +			display0: panel {
>   				bits-per-pixel = <16>;
>   				atmel,lcdcon-backlight;
>   				atmel,dmacon = <0x1>;
> diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts b/arch/arm/boot/dts/at91sam9m10g45ek.dts
> index 46107c2f1ab9..5226e952a729 100644
> --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts
> +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts
> @@ -236,7 +236,7 @@
>   			display = <&display0>;
>   			status = "okay";
>   
> -			display0: display {
> +			display0: panel {
>   				bits-per-pixel = <32>;
>   				atmel,lcdcon-backlight;
>   				atmel,dmacon = <0x1>;
> diff --git a/arch/arm/boot/dts/at91sam9rlek.dts b/arch/arm/boot/dts/at91sam9rlek.dts
> index 27d8a1f44233..a000a459f17b 100644
> --- a/arch/arm/boot/dts/at91sam9rlek.dts
> +++ b/arch/arm/boot/dts/at91sam9rlek.dts
> @@ -37,7 +37,7 @@
>   			display = <&display0>;
>   			status = "okay";
>   
> -			display0: display {
> +			display0: panel {
>   				bits-per-pixel = <16>;
>   				atmel,lcdcon-backlight;
>   				atmel,dmacon = <0x1>;
> 


-- 
Nicolas Ferre




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux