Hi, On Mon, 20 May 2019 at 09:36, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > On Sat, May 18, 2019 at 05:23:53PM +0200, Clément Péron wrote: > > Allwinner H6 has a watchog node which seems broken > > on some boards. > > > > Test has been performed on several boards. > > > > Chen-Yu Tsai boards: > > Pine H64 - H6448BA 7782 => OK > > OrangePi Lite 2 - H8068BA 61C2 => KO > > > > Martin Ayotte boards: > > Pine H64 - H8069BA 6892 => OK > > OrangePi 3 - HA047BA 69W2 => KO > > OrangePi One Plus - H7310BA 6842 => KO > > OrangePi Lite2 - H6448BA 6662 => KO > > > > Clément Péron board: > > Beelink GS1 - H7309BA 6842 => KO > > > > As it seems not fixable for now, declare the node > > but leave it disable with a comment. > > > > Signed-off-by: Clément Péron <peron.clem@xxxxxxxxx> > > If it doesn't work most boards, then why do we need to merge that > patch in the first place? My personnal opinion, is that having the IP declared and disabled with a comment saying "it's broken on some boards" in the device-tree is better than not having at all. This will explicit say "the IP exist but don't use it!". Maybe some people with a functionnal board would like to explicitly use it on their dts. Again just my personnal opinion, Thanks for the review, Clément > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
