Hi Maxime, On Mon, 20 May 2019 at 09:35, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > On Sat, May 18, 2019 at 05:23:52PM +0200, Clément Péron wrote: > > Allwinner H6 has a similar watchdog as the A64 which is already > > a compatible of the A31. > > > > This commit sort the lines and add the H6 compatible. > > > > Signed-off-by: Clément Péron <peron.clem@xxxxxxxxx> > > --- > > .../devicetree/bindings/watchdog/sunxi-wdt.txt | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt b/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt > > index 46055254e8dd..f4810f8ad1c5 100644 > > --- a/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt > > +++ b/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt > > @@ -3,10 +3,12 @@ Allwinner SoCs Watchdog timer > > Required properties: > > > > - compatible : should be one of > > - "allwinner,sun4i-a10-wdt" > > - "allwinner,sun6i-a31-wdt" > > - "allwinner,sun50i-a64-wdt","allwinner,sun6i-a31-wdt" > > - "allwinner,suniv-f1c100s-wdt", "allwinner,sun4i-a10-wdt" > > That sorting was kind of intentional Arg indeed, I will remove it. > > > + - "allwinner,sun4i-a10-wdt" > > + - "allwinner,sun50i-a64-wdt","allwinner,sun6i-a31-wdt" > > + - "allwinner,sun50i-h6-wdt","allwinner,sun50i-a64-wdt", > > + "allwinner,sun6i-a31-wdt" > > Is there a reason to keep the A64 compatible? Yes, A64 and H6 has the exact same memory mapping looking at the datasheet. So if there is an errata or a new feature for the A64, it should be also compatible with the H6. Which is not the case with A31 (WDT_KEY_FIELD is not preset) Thanks, Clement > > Thanks, > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
