Re: [PATCH v4 1/2] dt-bindings: leds: Add binding for spi-byte LED.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> From: Christian Mauderer <oss@xxxxxxxxxxxxx>
> 
> This patch adds the binding documentation for a simple SPI based LED
> controller which use only one byte for setting the brightness.
> 
> Signed-off-by: Christian Mauderer <oss@xxxxxxxxxxxxx>
> ---

> diff --git a/Documentation/devicetree/bindings/leds/leds-spi-byte.txt b/Documentation/devicetree/bindings/leds/leds-spi-byte.txt
> new file mode 100644
> index 000000000000..28b6b2d9091e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-spi-byte.txt
> @@ -0,0 +1,44 @@
> +* Single Byte SPI LED Device Driver.

> +The driver can be used for controllers with a very simple SPI protocol:
> +- one LED is controlled by a single byte on MOSI
> +- the value of the byte gives the brightness between two values (lowest to
> +  highest)
> +- no return value is necessary (no MISO signal)

I'd expect this file to be named acb-spi-led.txt, or something, and
talk about that u-controller, not its device driver -- as devicetree
binding describes hardware, not driver.

But you already have an ack from rob, so...
									Pavel
									
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux