Em Mon, 15 Apr 2019 14:44:08 +0200
Marco Felsch <m.felsch@xxxxxxxxxxxxxx> escreveu:
> From: Michael Tretter <m.tretter@xxxxxxxxxxxxxx>
>
> There are several debug prints in the tvp5150_parse_dt() function, which
> do not print the prefix, because the v4l2_subdev is not initialized, yet.
>
> Initialize the v4l2_subdev before parsing the device tree to fix the
> debug messages.
>
> Signed-off-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx>
> Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
Looks ok to me.
> ---
> drivers/media/i2c/tvp5150.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index 9331609425bf..305a5e256b31 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -1973,6 +1973,9 @@ static int tvp5150_probe(struct i2c_client *c,
>
> core->regmap = map;
> sd = &core->sd;
> + v4l2_i2c_subdev_init(sd, c, &tvp5150_ops);
> + sd->internal_ops = &tvp5150_internal_ops;
> + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
>
> if (IS_ENABLED(CONFIG_OF) && np) {
> res = tvp5150_parse_dt(core, np);
> @@ -1985,10 +1988,6 @@ static int tvp5150_probe(struct i2c_client *c,
> core->mbus_type = V4L2_MBUS_BT656;
> }
>
> - v4l2_i2c_subdev_init(sd, c, &tvp5150_ops);
> - sd->internal_ops = &tvp5150_internal_ops;
> - sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> -
> res = tvp5150_mc_init(core);
> if (res)
> goto err_cleanup_dt;
Thanks,
Mauro
