Hi Liviu, On 2014-3-14 23:34, Liviu Dudau wrote: > Several platforms use a rather generic version of parsing > the device tree to find the host bridge ranges. Move the common code > into the generic PCI code and use it to create a pci_host_bridge > structure that can be used by arch code. > > Based on early attempts by Andrew Murray to unify the code. > Used powerpc and microblaze PCI code as starting point. > > Signed-off-by: Liviu Dudau <Liviu.Dudau@xxxxxxx> > Tested-by: Tanmay Inamdar <tinamdar@xxxxxxx> > --- > drivers/pci/host-bridge.c | 158 ++++++++++++++++++++++++++++++++++++ > include/linux/pci.h | 13 +++ > 2 files changed, 171 insertions(+) > > diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c > index 8708b652..7cda90b 100644 > --- a/drivers/pci/host-bridge.c > +++ b/drivers/pci/host-bridge.c > @@ -6,9 +6,14 @@ > #include <linux/init.h> > #include <linux/pci.h> > #include <linux/module.h> > +#include <linux/of_address.h> > +#include <linux/of_pci.h> > +#include <linux/slab.h> > > #include "pci.h" > > +static atomic_t domain_nr = ATOMIC_INIT(-1); domain_nr will only be used inside the #ifdef CONFIG_OF, and this will lead to compile warning which complains that 'domain_nr' defined but not used when CONFIG_OF=n (for example on x86). How about moving the definition to ---> > + > static struct pci_bus *find_pci_root_bus(struct pci_bus *bus) > { > while (bus->parent) > @@ -92,3 +97,156 @@ void pcibios_bus_to_resource(struct pci_bus *bus, struct resource *res, > res->end = region->end + offset; > } > EXPORT_SYMBOL(pcibios_bus_to_resource); > + > +#ifdef CONFIG_OF here? Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html