On Mon, Apr 07, 2014 at 10:54:08PM +0100, tthayer@xxxxxxxxxx wrote:
> From: Thor Thayer <tthayer@xxxxxxxxxx>
>
> Addition of the Altera SDRAM EDAC bindings and device
> tree changes to the Altera SoC project.
>
> Signed-off-by: Thor Thayer <tthayer@xxxxxxxxxx>
> To: Rob Herring <robherring2@xxxxxxxxx>
> To: Pawel Moll <pawel.moll@xxxxxxx>
> To: Mark Rutland <mark.rutland@xxxxxxx>
> To: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>
> To: Kumar Gala <galak@xxxxxxxxxxxxxx>
> To: Rob Landley <rob@xxxxxxxxxxx>
> To: Russell King <linux@xxxxxxxxxxxxxxxx>
> To: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-doc@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> ---
> .../bindings/arm/altera/socfpga-sdram-edac.txt | 12 ++++++++++++
> arch/arm/boot/dts/socfpga.dtsi | 5 +++++
> 2 files changed, 17 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.txt b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.txt
> new file mode 100644
> index 0000000..9348c53
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.txt
> @@ -0,0 +1,12 @@
> +Altera SOCFPGA SDRAM Error Detection & Correction [EDAC]
> +
> +Required properties:
> +- compatible : should contain "altr,sdr-edac";
> +- interrupts : Should contain the SDRAM ECC IRQ in the
> + appropriate format for the IRQ controller.
> +
> +Example:
> + sdramedac@0 {
Nit: If there's no reg, there shouldn't be a unit-address (the "@0").
> + compatible = "altr,sdram-edac";
> + interrupts = <0 39 4>;
> + };
No phandle to the actual SDRAM controller node? Is there a guaranteed
limitation of a single SDRAM controller?
I don't see the point in describing this separately from the main SDRAM
controller node, given this seems to be a subcomponent.
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 6ce912e..a0ea69b 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -681,6 +681,11 @@
> reg = <0xffc25000 0x1000>;
> };
>
> + sdramedac@0 {
Nit: get rid of the unit-address here too.
Cheers,
Mark.
> + compatible = "altr,sdram-edac";
> + interrupts = <0 39 4>;
> + };
> +
> rstmgr@ffd05000 {
> compatible = "altr,rst-mgr";
> reg = <0xffd05000 0x1000>;
> --
> 1.7.9.5
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
