On Mon, Apr 07, 2014 at 02:31:00PM -0700, Bryan Wu wrote: > On Sun, Apr 6, 2014 at 3:18 PM, Russell King - ARM Linux > <linux@xxxxxxxxxxxxxxxx> wrote: > > This patch series fixes various problems with leds-pwm. > > > > The first patch is very important to solve a boot time oops on OMAP > > boards (and probably others) which has recently shown its face. > > > > The next two clean up leds-pwm so that we can avoid the madness of > > having entirely separate initialisation paths for DT and non-DT, which > > I believe is the core cause of the initial problem. > > > > The last two patches add support for LEDs connected in the opposite > > sense to PWM outputs, where either the PWM does not support inversion, > > or does not support it in a way that works sanely with leds-pwm. These > > add a new property to leds-pwm, hence why that patch (and this cover) > > copies the DT people. > > > > The first patch is an absolute must for going. > > > > Cool, I think Thierry is good for this patchset. I'm going to merge it > with Thierry's ack and queue it for 3.16 merge window. I don't mind the majority of the patch set being queued for the next merge window, but I object to the first patch being delayed. The first patch is a very necessary bug fix for a regression that has cropped up since -rc7. It may not be the fault of leds-pwm, but it's leds-pwm which is most certainly buggy. kfree'ing a work_struct which is active is *not* on. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html