On Tue, May 7, 2019 at 12:36 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > On Mon, May 06, 2019 at 03:03:15PM +0530, Jagan Teki wrote: > > On Fri, May 3, 2019 at 8:16 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > > > > > On Fri, May 03, 2019 at 05:29:28PM +0530, Jagan Teki wrote: > > > > Add Ethernet support for orangepi-one-plus board, > > > > > > > > - Ethernet port connected via RTL8211E PHY > > > > - PHY suppiled with > > > > GMAC-2V5, fixed regulator with GMAC_EN pin via PD6 > > > > GMAC-3V, which is supplied by VCC3V3-MAC via aldo2 > > > > - RGMII-RESET pin connected via PD14 > > > > > > > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > > > > > Your commit log should be improved. We can get those informations from > > > the patch itself... > > > > Thought it was a clear commit log :) will update anyway. > > Well, yes and no. The commit log is clear indeed, but it doesn't > provide what it's supposed to provide. > > You shouldn't put *what* is being done by the patch. That's pretty > easy to figure out by reading the patch itself. You have to explain > why and how you did it, which is lacking in that case. Make sense, will rework.
