On 06-05-19, 23:55, Bjorn Andersson wrote:
> On Mon 06 May 22:35 PDT 2019, Vinod Koul wrote:
>
> > On 06-05-19, 21:31, Niklas Cassel wrote:
> > > Add device bindings for CPUs to suspend using PSCI as the enable-method.
> > >
> > > Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxxxxx>
> > > ---
> > > arch/arm64/boot/dts/qcom/qcs404.dtsi | 15 +++++++++++++++
> > > 1 file changed, 15 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> > > index ffedf9640af7..f9db9f3ee10c 100644
> > > --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> > > @@ -31,6 +31,7 @@
> > > reg = <0x100>;
> > > enable-method = "psci";
> > > next-level-cache = <&L2_0>;
> > > + cpu-idle-states = <&CPU_PC>;
> > > };
> > >
> > > CPU1: cpu@101 {
> > > @@ -39,6 +40,7 @@
> > > reg = <0x101>;
> > > enable-method = "psci";
> > > next-level-cache = <&L2_0>;
> > > + cpu-idle-states = <&CPU_PC>;
> > > };
> > >
> > > CPU2: cpu@102 {
> > > @@ -47,6 +49,7 @@
> > > reg = <0x102>;
> > > enable-method = "psci";
> > > next-level-cache = <&L2_0>;
> > > + cpu-idle-states = <&CPU_PC>;
> > > };
> > >
> > > CPU3: cpu@103 {
> > > @@ -55,12 +58,24 @@
> > > reg = <0x103>;
> > > enable-method = "psci";
> > > next-level-cache = <&L2_0>;
> > > + cpu-idle-states = <&CPU_PC>;
> > > };
> > >
> > > L2_0: l2-cache {
> > > compatible = "cache";
> > > cache-level = <2>;
> > > };
> > > +
> > > + idle-states {
> >
> > Since we are trying to sort the file per address and
> > alphabetically, it would be great if this can be moved before l2-cache
> > :)
> >
>
> Picked up, with the order adjusted.
>
> > Other than that this lgtm
> >
>
> I presume that lgtm == Reviewed-by...
yes :-) and formally here as well..
Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx>
>
> Thanks,
> Bjorn
>
> > > + CPU_PC: pc {
> > > + compatible = "arm,idle-state";
> > > + arm,psci-suspend-param = <0x40000003>;
> > > + entry-latency-us = <125>;
> > > + exit-latency-us = <180>;
> > > + min-residency-us = <595>;
> > > + local-timer-stop;
> > > + };
> > > + };
> > > };
> > >
> > > firmware {
> > > --
> > > 2.21.0
> >
> > --
> > ~Vinod
--
~Vinod
