Re: [PATCH 1/2] dt-bindings: leds: Add binding for ubnt-spi LED.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 5/5/19 12:17 AM, Pavel Machek wrote:
Hi!

I wasn't aware of that list. Maybe "power" or even better "status" would
match the function.

Hmm, I've just found out that there are two "wlan-ap" occurrences in
the existing mainline bindings, so I propose to follow that.

Let me see... dove-d3plug.dts has "status", "wlan-ap", "wlan-act".

Should I add the color too? So "white:status"?

Yes, why not if it is known. So, having the above I propose:

		label = "white:wlan-ap";

Linux now runs on many different devices, and I believe userland wants
to know "this is main notification LED for this device" (and the only
one in this case).

This LED is on the access point, so it should have this affiliation
somehow represented in the name.

...and I guess if you have single LED it will be used for more than
"is AP active". IOW it will likely to be more similar to "status" than
"wlan-ap".

IMO if a LED is on some specific device, then it should be reflected
in the "function" section of the LED name. It facilitates locating in
physically. If usersapce wants to change its purpose it is free to do
so. e.g. via triggers. But it will not affect the LED name.

--
Best regards,
Jacek Anaszewski



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux