On 05/05/2019 00:17, Pavel Machek wrote: > Hi! > >>>> I wasn't aware of that list. Maybe "power" or even better "status" would >>>> match the function. >>> >>> Hmm, I've just found out that there are two "wlan-ap" occurrences in >>> the existing mainline bindings, so I propose to follow that. > > Let me see... dove-d3plug.dts has "status", "wlan-ap", "wlan-act". > >>>> Should I add the color too? So "white:status"? >>> >>> Yes, why not if it is known. So, having the above I propose: >>> >>> label = "white:wlan-ap"; >> >> Linux now runs on many different devices, and I believe userland wants >> to know "this is main notification LED for this device" (and the only >> one in this case). > > ...and I guess if you have single LED it will be used for more than > "is AP active". IOW it will likely to be more similar to "status" than > "wlan-ap". > > Best regards, > Pavel > As far as I understand it the dt-bindings is an example anyway, right? So it's not really relevant what the LED does in my specific system. Jacek said > In label we expect "color:function" pattern. Therefore I think that a "white:status" would be a good example label and I'll use that. I'll prepare a patch set v2 and (hopefully) send it in the next hours after I've tested in on my hardware. Best regards Christian
