Hi, Am 04.05.19 um 18:01 schrieb Chuanhong Guo: > Hi! > > On Mon, Apr 22, 2019 at 2:41 PM Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote: >> [...] >> - most of deficetree bindings was removed. Not every thing made sense >> and most of it is SoC specific, so it is possible to detect it by >> compatible. > > I noticed that you've dropped all PLL and gmac-config stuff. These are > board-specific properties and PLL registers should be changed > accroding to negotiated ethernet speed. By dropping them, you rely on > bootloader to configure everything corectly for you (which has been > proven unreliable for many ath79 routers) and ethernet won't work if > negotiated speed changed after u-boot's configuration. Both of them should be properly implemented before mainlining. This is the reason why they removed. -- Regards, Oleksij
