On 04/23/2019 12:22 PM, masonccyang@xxxxxxxxxxx wrote: >> > Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. >> > >> > Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx> >> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> >> [...] >> >> Do dote that I'm opposed to the driver separation as it's presented in >> this patches, and I have a large patch reworking both MFD and SPI drivers >> in the works. >> > > Do you mean add your name in both MFD & dt-binding ? Of course not! > i.e., > [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings > > Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD. > > Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > > > [PATCH v12 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD driver > > Add a driver for Renesas R-Car Gen3 RPC-IF MFD. > > Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > > Is it ok ? I'm not OK with the most of the driver code ending up in the SPI driver, I think most of the code should be kept in the MFD driver and just be called by SPI/HF drivers. > best regards, > Mason MBR, Sergei
