On Fri, 2014-04-04 at 12:15AM +0530, Harini Katakam wrote:
> Hi Soren
>
> On Thu, Apr 3, 2014 at 11:20 PM, Sören Brinkmann
> <soren.brinkmann@xxxxxxxxxx> wrote:
> > Hi Punnaiah,
> >
> > On Thu, 2014-04-03 at 10:33PM +0530, Punnaiah Choudary Kalluri wrote:
> >> Add bindings documentation for Zynq Quad SPI driver.
> >>
> >> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xxxxxxxxxx>
> >> ---
> >> .../devicetree/bindings/spi/spi-zynq-qspi.txt | 26 ++++++++++++++++++++
> >> 1 file changed, 26 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/spi/spi-zynq-qspi.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/spi/spi-zynq-qspi.txt b/Documentation/devicetree/bindings/spi/spi-zynq-qspi.txt
> >> new file mode 100644
> >> index 0000000..88e00f8
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/spi/spi-zynq-qspi.txt
> >> @@ -0,0 +1,26 @@
> >> +Xilinx Zynq QSPI controller Device Tree Bindings
> >> +-------------------------------------------------
> >> +
> >> +Required properties:
> >> +- compatible : Should be "xlnx,zynq-qspi-1.0".
> >> +- reg : Physical base address and size of QSPI registers map.
> >> +- interrupts : Property with a value describing the interrupt
> >> + number.
> >> +- interrupt-parent : Must be core interrupt controller
> >> +- clock-names : List of input clock names - "ref_clk", "aper_clk"
> >> + (See clock bindings for details).
> >> +- clocks : Clock phandles (see clock bindings for details).
> >> +
> >> +Optional properties:
> >> +- num-cs : Number of chip selects used.
> >> +
> >> +Example:
> >> + qspi@e000d000 {
> >> + compatible = "xlnx,zynq-qspi-1.0";
> >> + clock-names = "ref_clk", "aper_clk";
> >
> > These seem to be the SOC names of the clocks. Doesn't have the IP its
> > own naming for these clock inputs?
> >
>
> The IP design spec uses the name ref_clk.
> There is no particular clock name used for for APB clock.
> So I think aper_clk is a valid name to use.
aper is a Zynq-ism, IMHO. I think 'pclk', 'apbclk' or
something like that is more appropriate.
Sören
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
