Hi, On Tue, 16 Apr 2019 at 09:34, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > On Mon, Apr 15, 2019 at 06:30:10PM +0200, Clément Péron wrote: > > > > I didn't change the driver and the SPDIF is working what's irrelevant > > > > in declaring the driver as compatible ? > > > > > > It's working by accident. > > > > > > This won't work for example: > > > https://elixir.bootlin.com/linux/latest/source/sound/soc/sunxi/sun4i-spdif.c#L181 > > > > > > > If some feature are missing they can be introduce later as there is a > > > > special binding for H6 no ? > > > > > > Again, that's irrelevant. The only question you need to ask yourself > > > is whether, if you take an imaginary source code that would support > > > all the H3 SPDIF features and run it on an H6, it works just as well. > > > > > > The examples above that it's not the case, so you can't claim that the > > > device is compatible. > > > > Is it ok if I fix the TX Fifo flush bit and remove the compatible with H3 ? > > (Looking at the driver this is the only bit used that is incompatible with H6) > > Sure > > > Or should I send a new driver with the correct mapping ? > > No, we definitely don't want to duplicate a driver just for a single > bit offset that changes. Thanks for the advice, I will try to submit a new version with this fix. Clement > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
