Hi, On Mon, 15 Apr 2019 at 10:04, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > Hi, > > On Thu, Apr 11, 2019 at 11:44:19PM +0200, Clément Péron wrote: > > Allwinner H6 has a SPDIF controller with an increase of the fifo > > size and the possibility to output the master clock. > > However it's still compatible with the already existing driver for > > Allwiner H3. > > > > Add this compatible in the device-tree bindings documentation. > > How was this tested? Using Alsa utils on a Beelink GS1 and I check correct output sound on my home cinema. > > After looking at the datasheet, it looks like it's still significantly > different. In particular: > > - The MCLK divider isn't at the same offset We don't use the MCLK > - The bits to flush the FIFO aren't at the same offset > - The FIFO trigger levels aren't at the same offset > - The FIFO status register layout is almost entirely different We use DMA not FIFO Clement > > So it doesn't really look compatible to me > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
