Hi Dong-san, On Thu, Apr 11, 2019 at 04:54:12PM +0900, Cao Van Dong wrote: > Add fdp1 node to dtsi for FDP1 support on the RZ/G1C (r8a77470) SoC. > > Signed-off-by: Cao Van Dong <cv-dong@xxxxxxxxxxx> > --- > arch/arm/boot/dts/r8a77470.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi > index 2540bca..7881516 100644 > --- a/arch/arm/boot/dts/r8a77470.dtsi > +++ b/arch/arm/boot/dts/r8a77470.dtsi > @@ -1131,6 +1131,15 @@ > resets = <&cpg 128>; > }; > > + fdp1@fe940000 { > + compatible = "renesas,fdp1"; > + reg = <0 0xfe940000 0 0x2400>; > + interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 119>; > + power-domains = <&sysc R8A77470_PD_ALWAYS_ON>; > + resets = <&cpg 119>; > + }; > + Nodes should be sorted by 1. Bus address 2. IP block tupe So the above vsp nodes should not go before sd@ee100000. Otherwise this patch looks good to me. > sdhi0: sd@ee100000 { > compatible = "renesas,sdhi-r8a77470", > "renesas,rcar-gen2-sdhi"; > -- > 2.7.4 >