On Thu, Apr 11, 2019 at 04:54:11PM +0900, Cao Van Dong wrote: > Add vsp nodes to dtsi for VSP support on the RZ/G1C (r8a77470) SoC. > > Signed-off-by: Cao Van Dong <cv-dong@xxxxxxxxxxx> > --- > arch/arm/boot/dts/r8a77470.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi > index ae1dba0..2540bca 100644 > --- a/arch/arm/boot/dts/r8a77470.dtsi > +++ b/arch/arm/boot/dts/r8a77470.dtsi > @@ -1113,6 +1113,24 @@ > status = "disabled"; > }; > > + vsp@fe928000 { > + compatible = "renesas,vsp1"; > + reg = <0 0xfe928000 0 0x8000>; > + interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 131>; > + power-domains = <&sysc R8A77470_PD_ALWAYS_ON>; > + resets = <&cpg 131>; > + }; > + > + vsp@fe930000 { > + compatible = "renesas,vsp1"; > + reg = <0 0xfe930000 0 0x8000>; > + interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 128>; > + power-domains = <&sysc R8A77470_PD_ALWAYS_ON>; > + resets = <&cpg 128>; > + }; > + Nodes should be sorted by 1. Bus address 2. IP block tupe So the above vsp nodes should go after sd@ee100000. Otherwise this patch looks good to me. > sdhi0: sd@ee100000 { > compatible = "renesas,sdhi-r8a77470", > "renesas,rcar-gen2-sdhi"; > -- > 2.7.4 >