Arnd Bergmann wrote:
>
[...]
> >
> > .../devicetree/bindings/ata/exynos-sata-phy.txt | 14 ---------
> > .../devicetree/bindings/ata/exynos-sata.txt | 25
+++++++++------
> > .../devicetree/bindings/phy/samsung-phy.txt | 36
> > ++++++++++++++++++++++
>
> Looking through the branch contents, I noticed that the examples in the
> bindings contain mandatory properties that are not documented.
>
Oops, sorry.
> I have merged your branch into next/cleanup3 of the arm-soc tree,
> but I also applied a patch on top to document the missing strings
> and properties. It is currently the top commit on the branch, so
> if anyone spots a mistake, we can probably rectify it.
>
Thanks a lot :-)
> Please be more careful with binding documentation in the future.
> Was this actually reviewed on the devicetree-discuss mailing list?
>
Sure.
- Kukjin
> Arnd
>
> 9<-----
> From 9dfbff16b422a4bac7ad309847c7bc5d65653392 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@xxxxxxxx>
> Date: Sat, 29 Mar 2014 02:15:43 +0100
> Subject: [PATCH] devicetree: fix newly added exynos sata bindings
>
> Commit ba0d7ed391b7b "ARM: dts: enable ahci sata and sata phy for
> exynos5250" added a new binding document for the sata phy device,
> and changed the sata controller binding. However, in both cases
> significant aspects of the binding remained undocumented.
> This attempts to reconstruct the actual binding from the usage.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Yuvaraj Kumar C D <yuvaraj.cd@xxxxxxxxxxx>
> Cc: Kishon Vijay Abraham I <kishon@xxxxxx>
> Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
>
> diff --git a/Documentation/devicetree/bindings/ata/exynos-sata.txt
> b/Documentation/devicetree/bindings/ata/exynos-sata.txt
> index b2adb1f..cb48448 100644
> --- a/Documentation/devicetree/bindings/ata/exynos-sata.txt
> +++ b/Documentation/devicetree/bindings/ata/exynos-sata.txt
> @@ -8,8 +8,14 @@ Required properties:
> - interrupts : <interrupt mapping for SATA IRQ>
> - reg : <registers mapping>
> - samsung,sata-freq : <frequency in MHz>
> -- phys : as mentioned in phy-bindings.txt
> -- phy-names : as mentioned in phy-bindings.txt
> +- phys : Must contain exactly one entry as
specified
> + in phy-bindings.txt
> +- phy-names : Must be "sata-phy"
> +
> +Optional properties:
> +- clocks : Must contain an entry for each entry in
clock-names.
> +- clock-names : Shall be "sata" for the external SATA bus
> clock,
> + and "sclk_sata" for the internal controller clock.
>
> Example:
> sata@122f0000 {
> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt
> b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> index a937f75..67d38b3 100644
> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> @@ -30,7 +30,11 @@ Each SATA PHY controller should have its own node.
> Required properties:
> - compatible : compatible list, contains "samsung,exynos5250-sata-
> phy"
> - reg : offset and length of the SATA PHY register set;
> -- #phy-cells : from the generic phy bindings;
> +- #phy-cells : must be zero
> +- clocks : must be exactly one entry
> +- clock-names : must be "sata_phyctrl"
> +- samsung,exynos-sataphy-i2c-phandle : a phandle to the I2C device, no
> arguments
> +- samsung,syscon-phandle : a phandle to the PMU system controller, no
> arguments
>
> Example:
> sata_phy: sata-phy@12170000 {
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
