On Fri, Apr 05, 2019 at 02:25:54PM +0200, Miquel Raynal wrote: > Hi Maxime, > > Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote on Fri, 5 Apr 2019 > 12:55:59 +0200: > > > On Fri, Apr 05, 2019 at 11:37:42AM +0200, Miquel Raynal wrote: > > > Hi Maxime, > > > > > > Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote on Fri, 5 Apr 2019 > > > 11:16:07 +0200: > > > > > > > On Thu, Apr 04, 2019 at 06:21:10PM +0200, Miquel Raynal wrote: > > > > > Allwinner NAND controllers can make use of DMA to enhance the I/O > > > > > throughput thanks to ECC pipelining. DMA handling with sun8i NAND IP > > > > > is a bit different than with the older SoCs, hence the introduction of > > > > > a new compatible to handle: > > > > > * the differences between register offsets, > > > > > * the burst length change from 4 to minimum 8, > > > > > * drive SRAM accesses through the AHB bus instead of the MBUS. > > > > > > > > > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > > > > > --- > > > > > drivers/mtd/nand/raw/sunxi_nand.c | 75 ++++++++++++++++++++++++++++--- > > > > > 1 file changed, 68 insertions(+), 7 deletions(-) > > > > > > > > > > diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c > > > > > index 4282bc477761..49cd5067adaa 100644 > > > > > --- a/drivers/mtd/nand/raw/sunxi_nand.c > > > > > +++ b/drivers/mtd/nand/raw/sunxi_nand.c > > > > > @@ -42,7 +42,8 @@ > > > > > #define NFC_REG_CMD 0x0024 > > > > > #define NFC_REG_RCMD_SET 0x0028 > > > > > #define NFC_REG_WCMD_SET 0x002C > > > > > -#define NFC_REG_IO_DATA 0x0030 > > > > > +#define NFC_REG_A10_IO_DATA 0x0030 > > > > > +#define NFC_REG_A33_IO_DATA 0x0300 > > > > > #define NFC_REG_ECC_CTL 0x0034 > > > > > #define NFC_REG_ECC_ST 0x0038 > > > > > #define NFC_REG_DEBUG 0x003C > > > > > @@ -200,6 +201,22 @@ static inline struct sunxi_nand_chip *to_sunxi_nand(struct nand_chip *nand) > > > > > return container_of(nand, struct sunxi_nand_chip, nand); > > > > > } > > > > > > > > > > +/* > > > > > + * NAND Controller capabilities structure: stores NAND controller capabilities > > > > > + * for distinction between compatible strings. > > > > > + * > > > > > + * @sram_through_ahb: On A33, we choose to access the internal RAM through AHB > > > > > + * instead of MBUS (less configuration). A10+ use the MBUS > > > > > > > > What do you mean by A10+ ? > > > > > > I meant A1x, A2x SoCs. Not sure it matches a product line for you, so > > > please suggest something to mean "SoCs which are not A33" (so far I > > > think all worked without this). > > > > The list is pretty small, so we can just name them. That would be the > > A10, A10s A13 and A20. > > You really need a "A10+"-like acronym for these ;) A10, A10s, A13, A20 and GR8 but not A23, A31, A33, A64, A80, A83t, or any SoC that is still not out yet. A10+ doesn't look like the most appropriate fit for that list :) Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
