On Sat, Mar 29, 2014 at 12:54:40PM +0100, Rafał Miłecki wrote: > Hi guys, > > I've noticed gpio_wdt was added to the kernel to support some devices > based on devicetree. > We used to have our own (not mainlined) gpio_wdt in OpenWrt project: > http://git.openwrt.org/?p=openwrt.git;a=blob;f=target/linux/generic/patches-3.10/990-gpio_wdt.patch;hb=HEAD > > The main difference is that the mainlined one uses OF, while OpenWrt's > one uses plain platform API (with struct gpio_wdt_platform_data). > > I wanted to bring a topic of mainlining OpenWrt's solution. We > definitely need that and at the same time our device(s) don't use OF / > DT. > > Do you think we should extend wdt-gpio to handle that? Or do you think > this driver is so small, it's not worth it and we should submit a > separated one? > > Apart from API being used, one other difference I see is OpenWrt > supports different values for "first tick" and "interval". But that > could be easily handled. > If you can sort out those differences, I would suggest to add platform data support to the existing upstream driver. Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
