Re: [PATCH] power: supply: ltc3651-charger.c: Fix typo in device name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 26, 2019 at 02:57:15PM +0100, michael.hennerich@xxxxxxxxxx wrote:
> From: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

Seems to be a bit more than 'fix a typo'.

> 
> There never was a device called LTC3651, it always was just LT3651.
> This circumstance makes it pretty difficult to identify what this
> driver is meant to control. This patch is a minimal invasive attempt
> to fix this issue without affecting existing systems.
> 
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/power/supply/ltc3651-charger.txt         | 8 +++++---
>  drivers/power/supply/Kconfig                                     | 6 +++---
>  drivers/power/supply/ltc3651-charger.c                           | 9 +++------
>  3 files changed, 11 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt
> index 71f2840..f012449 100644
> --- a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt
> +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt
> @@ -1,7 +1,9 @@
> -ltc3651-charger
> +Analog Devices LT3651 Charger Power Supply bindings: ltc3651-charger
>  
>  Required properties:
> - - compatible: "lltc,ltc3651-charger"
> +- compatible: Should contain one of the following:
> + * "lltc,ltc3651-charger",

You should note that this one is deprecated.

> + * "lltc,lt3651-charger"
>   - lltc,acpr-gpios: Connect to ACPR output. See remark below.
>  
>  Optional properties:
> @@ -20,7 +22,7 @@ attributes to detect changes.
>  Example:
>  
>  	charger: battery-charger {
> -		compatible = "lltc,ltc3651-charger";
> +		compatible = "lltc,lt3651-charger";
>  		lltc,acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>;
>  		lltc,fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>;
>  		lltc,chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>;



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux