Sat, 29 Mar 2014 12:54:40 +0100 от Rafał Miłecki <zajec5@xxxxxxxxx>: > Hi guys, > > I've noticed gpio_wdt was added to the kernel to support some devices > based on devicetree. > We used to have our own (not mainlined) gpio_wdt in OpenWrt project: > http://git.openwrt.org/?p=openwrt.git;a=blob;f=target/linux/generic/patches-3.10/990-gpio_wdt.patch;hb=HEAD > > The main difference is that the mainlined one uses OF, while OpenWrt's > one uses plain platform API (with struct gpio_wdt_platform_data). > > I wanted to bring a topic of mainlining OpenWrt's solution. We > definitely need that and at the same time our device(s) don't use OF / > DT. > > Do you think we should extend wdt-gpio to handle that? Or do you think > this driver is so small, it's not worth it and we should submit a > separated one? > > Apart from API being used, one other difference I see is OpenWrt > supports different values for "first tick" and "interval". But that > could be easily handled. In fact, this driver can be extended to non-DT support without adding any platform_data headers. This can be implemented by convert driver to using descriptor-based GPIO functions (gpiod_{}). HW timeout value in this case can be taken with module_param(). --- ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
