On Mon, Mar 18, 2019 at 10:28:10PM +0530, Jagan Teki wrote: > On Fri, Mar 15, 2019 at 7:04 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > > > On Fri, Mar 15, 2019 at 06:38:23PM +0530, Jagan Teki wrote: > > > ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > > It has a flexible configuration of MIPI DSI signal input > > > and produce RGB565, RGB666, RGB888 output format. > > > > > > Add dt-bingings for it. > > > > > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > > --- > > > .../display/bridge/chipone,icn6211.txt | 36 +++++++++++++++++++ > > > 1 file changed, 36 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > new file mode 100644 > > > index 000000000000..7f13efd7ee7f > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > @@ -0,0 +1,36 @@ > > > +Chipone ICN6211 MIPI-DSI to RGB Convertor Bridge > > > + > > > +ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > > +It has a flexible configuration of MIPI DSI signal input > > > +and produce RGB565, RGB666, RGB888 output format. > > > + > > > +Required properties for RGB: > > > +- compatible: must be "chipone,icn6211" and one of: > > > + * "bananapi,icn6211" > > > > Why is that compatible needed? > > chipone,icn6211 - generic compatible bridge controller IC > bananapi,icn6211 - compatible for icn6211 bridge using on bananapi panel > > I hope this would be proper bindings in terms of controller IC with > associate device, anything wrong? Infact I used similar reference from > Ilitek Bananapi panel from here > Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt > > This is what I understood based on dt-binding, correct if I'm wrong. The ILI9881c is an LCD controller, and it has some panel specific configuration. Does your bridge have board specific configuration? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
