On Mon, 2019-03-11 at 12:47 -0500, Dan Murphy wrote: > On 3/11/19 12:30 PM, Joe Perches wrote: > > On Mon, 2019-03-11 at 12:24 -0500, Dan Murphy wrote: > > > checkpatch takes issue with // in headers. > > > Unless they have removed that requirement. [] > I guess I was referring to this SPDX warning > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > #1: FILE: drivers/net/can/m_can/m_can.h:1: > +//SPDX-License-Identifier: GPL-2.0 The general form uses a space after the // And much more recently: commit fdf13693d370653013eec3bc7f80a3f535001bf0 Author: Joe Perches <joe@xxxxxxxxxxx> Date: Thu Mar 7 16:28:32 2019 -0800 checkpatch: verify SPDX comment style Using SPDX commenting style // or /* is specified for various file types in Documentation/process/license-rules.rst so add an appropriate test for .[chsS] files because many proposed file additions and patches do not use the correct style.