Hi David, Am Samstag, 9. März 2019, 16:39:23 CET schrieb David Summers: > This patch is an outline for bluetooth on the ASUS Tinker Board (S). > > Bluetooth is provided my RTL8723BS on these machine, and this is wired > into UART0. > > Here this is performed as a SerDev device. > > Now as presented, this does not give functioning bluetooth. The > updates needed to the device driver: > > https://www.spinics.net/lists/linux-bluetooth/msg78661.html > > Haven't yet been accepted. So this device tree hook doesn't yet have > "realtek,rtl8723bs-bt" compatible flag. > > It is however still submitted as a patch, as it sets the UART up > correctly. And so basic communciation can be had with the device. This > has been confirmed by Tony McKahan @ Armbian, in particular that the > CTS/RTS is needed. > > When Vasily patch is accepted, this will be added as a minor patch on > top of this patch; as this patch gives the pins needed. > > The one oddity, is the RESET pin, it is labeled this way on the > schematic. However the hci_h5.c driver calls this ENABLE. Here we have > stuck with the schematic name. > > Signed-off-by: David Summers <beagleboard@xxxxxxxxxxxxxxxxxxx> > --- > arch/arm/boot/dts/rk3288-tinker.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi > b/arch/arm/boot/dts/rk3288-tinker.dtsi index 0ffab1b7c940..d29f5b34d7e6 > 100644 > --- a/arch/arm/boot/dts/rk3288-tinker.dtsi > +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi > @@ -486,6 +486,17 @@ > > &uart0 { > status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&uart0_xfer>, <&uart0_cts>, <&uart0_rts>; > + > + bluetooth { > + clocks = <&rk808 RK808_CLKOUT1>; > + reset-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_HIGH>; > + device-wake-gpios = <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>; > + host-wake-gpios = <&gpio4 RK_PD7 GPIO_ACTIVE_HIGH>; > + vcc-18-supply = <&vcc_18>; > + vcc-io-supply = <&vcc_io>; > + }; As this is supposed to work as serial attached device it should follow a dt-binding, so first of all definitly needs a compatible and a binding specifying all the properties declared above. See for example Documentation/devicetree/bindings/net/broadcom-bluetooth.txt for a similar device. Heiko
