Hi Vishal, Sakari, On 12/03/19 15:45, Vishal Sagar wrote: >>> +- xlnx,en-csi-v2-0: Present if CSI v2 is enabled in IP configuration. >>> +- xlnx,en-vcx: When present, there are maximum 16 virtual channels, else >>> + only 4. This is present only if xlnx,en-csi-v2-0 is present. >>> +- xlnx,en-active-lanes: present if the number of active lanes can be >>> + reconfigured at runtime in the Protocol Configuration Register. >>> + If present, the V4L2_CID_XILINX_MIPICSISS_ACT_LANES control is added. >>> + Otherwise all lanes, as set in IP configuration, are always active. >> >> The bindings document hardware, therefore a V4L2 control name doesn't >> belong here. >> > Ok. I will remove this and revert to original description as below - > > xlnx,en-active-lanes: present if the number of active lanes can be > re-configured at runtime in the Protocol Configuration Register I'm to blame here as I suggested that text. However I still find the original wording was ambiguous: my initial reading of it was close to the opposite of the intended meaning. xlnx,en-active-lanes means "a register exists to configure the active lanes at runtime" and I just care that this is stated clearly and unambiguously. If we cannot mention a control name here, why not just dropping it: - xlnx,en-active-lanes: present if the number of active lanes can be reconfigured at runtime in the Protocol Configuration Register. Otherwise all lanes are always active. -- Luca
