RE: [PATCH 1/2] dt-bindings: iio: accel: add LIS2DE12 sensor device binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Yes, you are right Jonathan.

I saw that before but since there are already 15 sensors that are not following my initial convention anymore, I decided to let it go...Not sure I'll be able to catch all of the patches.
But your point is actually correct. I know it's a small thing but anyway what do you thing about?

Denis


-----Original Message-----
From: Jonathan Cameron <jic23@xxxxxxxxxxxxxxxxxxxxx> 
Sent: Saturday, March 9, 2019 10:23 AM
To: Denis CIOCCA <denis.ciocca@xxxxxx>
Cc: Robert Jones <rjones@xxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; Hartmut Knaack <knaack.h@xxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] dt-bindings: iio: accel: add LIS2DE12 sensor device binding

On Sat, 9 Mar 2019 18:20:26 +0000
Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Sat, 9 Mar 2019 01:14:14 +0000
> Denis CIOCCA <denis.ciocca@xxxxxx> wrote:
> 
> > Acked-by: Denis Ciocca <denis.ciocca@xxxxxx>
> Applied to the togreg branch of iio.git and pushed out as testing for 
> the autobuilders to play with it.
> 
> Thanks
> 
> Jonathan
Actually, sorry too fast to click send!

Why the -accel postfix?

That is normally only done for devices with multiple separate sensors within them.  That isn't true as far as I can see for this one.

Jonathan

> 
> > 
> > Thanks,
> > Denis
> > 
> > 
> > -----Original Message-----
> > From: linux-iio-owner@xxxxxxxxxxxxxxx 
> > <linux-iio-owner@xxxxxxxxxxxxxxx> On Behalf Of Robert Jones
> > Sent: Tuesday, March 5, 2019 12:33 PM
> > To: Jonathan Cameron <jic23@xxxxxxxxxx>; Rob Herring 
> > <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>
> > Cc: devicetree@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; Hartmut 
> > Knaack <knaack.h@xxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; 
> > Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx>; Robert Jones 
> > <rjones@xxxxxxxxxxxxx>
> > Subject: [PATCH 1/2] dt-bindings: iio: accel: add LIS2DE12 sensor 
> > device binding
> > 
> > Signed-off-by: Robert Jones <rjones@xxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/iio/st-sensors.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/st-sensors.txt 
> > b/Documentation/devicetree/bindings/iio/st-sensors.txt
> > index 52ee4ba..7f24b33 100644
> > --- a/Documentation/devicetree/bindings/iio/st-sensors.txt
> > +++ b/Documentation/devicetree/bindings/iio/st-sensors.txt
> > @@ -49,6 +49,7 @@ Accelerometers:
> >  - st,lis2dw12
> >  - st,lis3dhh
> >  - st,lis3de
> > +- st,lis2de12-accel
> >  
> >  Gyroscopes:
> >  - st,l3g4200d-gyro
> 




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux