Hi Paul, > >> --- a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt > >> +++ b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt > >> @@ -6,7 +6,10 @@ memory-controllers/ingenic,jz4780-nemc.txt), and >> thus NAND device nodes must > >> be children of the NEMC node. > >> >> Required NAND controller device properties: > >> -- compatible: Should be set to "ingenic,jz4780-nand". > >> +- compatible: Should be one of: > >> + * ingenic,jz4740-nand > >> + * ingenic,jz4725b-nand > >> + * ingenic,jz4780-nand > > > > Wouldn't "-nand-controller" suffix be better? Of course in the driver > > you should still check for jz4780-nand. > > So I would be compatible with: > * ingenic,jz4740-nand-controller > * ingenic,jz4725b-nand-controller > * ingenic,jz4780-nand > ? >From a driver POV I would even prefer ingenic,jz4780-nand-controller. I don't know what's best here. Maybe Boris or Rob can help? Thanks, Miquèl
