On Tue, Feb 19, 2019 at 10:08:53AM +0000, Claudiu.Beznea@xxxxxxxxxxxxx wrote: > From: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> > > Add struct atmel_pwm_data to embed different per controller information. At > this stage, embed a member of type struct atmel_pwm_registers in it. I'd write: Introduce a new structure to describe per controller information. For now it contains only a struct atmel_pwm_registers member which up to now is enough to describe the relevant differences and was used directly as driver data before. This prepares adding support for another similar controller that needs additional information. Other than that Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
