On Tue, Feb 19, 2019 at 10:58:08AM +0100, Mathieu Othacehe wrote: > Add support for hi3559v100-shub-pwm and hisilicon,hi3559v100-pwm > platforms. They require a special quirk: pwm has to be enabled again > to force duty_cycle refresh. The patch looks fine now. (If you have to do another round: s/again/twice/ in the commit log and s/once more/twice/ in the comment below.) I wonder if this behaviour is a bug or a feature of the hardware. Is this additional enable needed to apply changes to both period and duty_cycle atomically? Is the 2nd enable needed independent of the PWM already running? Can you share the relevant part of the documentation without violating an NDA? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
