RE: [PATCH V4 4/4] MAINTAINERS: Added imx DDR performonitor driver maintainer information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Uwe Kleine-König [mailto:u.kleine-koenig@xxxxxxxxxxxxxx]
> Sent: Saturday, February 16, 2019 5:45 AM
> 
> On Fri, Feb 15, 2019 at 03:13:00PM -0600, Zhi Li wrote:
> > On Fri, Feb 15, 2019 at 2:01 PM Uwe Kleine-König
> > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> > >
> > > On Fri, Feb 15, 2019 at 06:03:16PM +0000, Frank Li wrote:
> > > > Add DDR perf counter driver maintainer information
> > > >
> > > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > > > ---
> > > > No change from v1 to v4
> > > >
> > > >  MAINTAINERS | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS index 6ba068e..687be0f
> > > > 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -6163,6 +6163,13 @@ L:     linux-i2c@xxxxxxxxxxxxxxx
> > > >  S:   Maintained
> > > >  F:   drivers/i2c/busses/i2c-cpm.c
> > > >
> > > > +FREESCALE IMX DDR Performance Monitor DRIVER
> > > > +M:   Frank Li <Frank.li@xxxxxxx>
> > > > +L:   linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > > > +S:   Maintained
> > > > +F:   drivers/perf/fsl_imx8_ddr_perf.c
> > > > +F:   Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > > > +
> > >
> > > With da8b7f0fb02b ("MAINTAINERS: add all files matching "imx" and "mxs"
> > > to the IMX entry") that sits currently in next the "ARM/FREESCALE
> > > IMX / MXC ARM ARCHITECTURE" also matches for these two files.
> > >
> > > Is this good here or not?
> >
> > Yes! what's do you means?
> > Needn't these entry because da8b7f0fb02b?
> 
> It's just that we then will have two entries that will match. In a tree where I
> have both, this series and da8b7f0fb02b I see:
> 
> 	$ scripts/get_maintainer.pl -f drivers/perf/fsl_imx8_ddr_perf.c
> 	Frank Li <Frank.li@xxxxxxx> (maintainer:FREESCALE IMX DDR
> Performance Monitor DRIVER)
> 	Will Deacon <will.deacon@xxxxxxx> (maintainer:ARM PMU PROFILING
> AND DEBUGGING)
> 	Mark Rutland <mark.rutland@xxxxxxx> (maintainer:ARM PMU
> PROFILING AND DEBUGGING)
> 	Shawn Guo <shawnguo@xxxxxxxxxx> (maintainer:ARM/FREESCALE IMX /
> MXC ARM ARCHITECTURE)
> 	Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> (maintainer:ARM/FREESCALE
> IMX / MXC ARM ARCHITECTURE)
> 	Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> 	Fabio Estevam <fabio.estevam@xxxxxxx> (reviewer:ARM/FREESCALE IMX
> / MXC ARM ARCHITECTURE)
> 	NXP Linux Team <linux-imx@xxxxxxx> (reviewer:ARM/FREESCALE IMX /
> MXC ARM ARCHITECTURE)
> 	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (open list:FREESCALE IMX DDR
> Performance Monitor DRIVER)
> 	linux-kernel@xxxxxxxxxxxxxxx (open list)
> 
> That's not necessarily a bad thing, but something I want people to make aware
> of.
> 

IMHO it's better to have a more specific maintainer in the MAINTAINER file
for a specific module.

Don't reply on the general pattern to filter all IMX patches to send ARCH
Maintainers to help review.

Regards
Dong Aisheng

> Best regards
> Uwe
> 
> --
> Pengutronix e.K.                           | Uwe Kleine-König
> |
> Industrial Linux Solutions                 |
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> pengutronix.de%2F&amp;data=02%7C01%7Caisheng.dong%40nxp.com%7C88
> f88bc0bd7e4812d00008d6938ed1af%7C686ea1d3bc2b4c6fa92cd99c5c3016
> 35%7C0%7C0%7C636858638948593375&amp;sdata=KwEG5SXUsLCgUU9pg8
> hnZ9JQq4%2FPGHA6EFhmF%2Bcmlo8%3D&amp;reserved=0  |




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux