Hi,
> David Summers <beagleboard@xxxxxxxxxxxxxxxxxxx> hat am 18. Februar 2019 um 21:26 geschrieben:
>
>
> On 17/02/2019 20:43, Stefan Wahren wrote:
> > Hi David,
> >
> >> David Summers <beagleboard@xxxxxxxxxxxxxxxxxxx> hat am 17. Februar 2019 um 13:15 geschrieben:
> >>
> >>
> >> +
> >> + sdio_pwrseq: sdio-pwrseq {
> >> + compatible = "mmc-pwrseq-simple";
> >> + clocks = <&rk808 RK808_CLKOUT1>;
> >> + clock-names = "ext_clock";
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&wifi_enable>;
> > As i wrote at the Arch board it would be nice to keep the Asus comment here:
> >
> > /*
> > * On the module itself this is one of these (depending
> > * on the actual card populated):
> > * - SDIO_RESET_L_WL_REG_ON
> > * - PDN (power down when low)
> > */
> >
> Sorry Stefan,
>
> I'm with Robin on this one.
i don't known anything about the reference design. So please ignore my comment.
>
>
> >> + reset-gpios = <&gpio4 RK_PD3 GPIO_ACTIVE_LOW>, <&gpio4 RK_PD4 GPIO_ACTIVE_LOW>;
> >> + };
> >> };
> >>
> >> &cpu0 {
> >> @@ -337,8 +345,8 @@
> >>
> >> &io_domains {
> >> status = "okay";
> >> -
> > Please drop this whitespace change
> Most {} in dts don't have white space line in - only between {} {}. So a
> white space line in the middle of a single {} is unusual. I can't see
> what its needed for, or what it makes clearer. So to me removing makes
> it more in line with everything else. If people are unhappy though I'll
> add the white line back in again.
I don't have a problem with dropping the empy line in general. But it's unrelated to this change. So please make it a separate patch or drop it completely.
