Re: [PATCH v3 2/3] [media] allegro: add Allegro DVT video IP core driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.0-rc4 next-20190213]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Michael-Tretter/Add-ZynqMP-VCU-Allegro-DVT-H-264-encoder-driver/20190214-090312
base:   git://linuxtv.org/media_tree.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.2.0 make.cross ARCH=sh 

All warnings (new ones prefixed by >>):

   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
   drivers/staging/media/allegro-dvt/allegro-core.c: In function 'allegro_mbox_write':
   include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/media/v4l2-common.h:72:14: note: in expansion of macro 'KERN_ERR'
     v4l2_printk(KERN_ERR, dev, fmt , ## arg)
                 ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:749:3: note: in expansion of macro 'v4l2_err'
      v4l2_err(&dev->v4l2_dev,
      ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:750:17: note: format string is defined here
        "message (%lu bytes) to large for mailbox (%lu bytes)\n",
                  ~~^
                  %u
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
   include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/media/v4l2-common.h:72:14: note: in expansion of macro 'KERN_ERR'
     v4l2_printk(KERN_ERR, dev, fmt , ## arg)
                 ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:749:3: note: in expansion of macro 'v4l2_err'
      v4l2_err(&dev->v4l2_dev,
      ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:750:50: note: format string is defined here
        "message (%lu bytes) to large for mailbox (%lu bytes)\n",
                                                   ~~^
                                                   %u
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
   include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/media/v4l2-common.h:72:14: note: in expansion of macro 'KERN_ERR'
     v4l2_printk(KERN_ERR, dev, fmt , ## arg)
                 ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:756:3: note: in expansion of macro 'v4l2_err'
      v4l2_err(&dev->v4l2_dev,
      ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:757:51: note: format string is defined here
        "invalid message length: %u bytes (expected %lu bytes)\n",
                                                    ~~^
                                                    %u
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
>> include/linux/kern_levels.h:5:18: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/media/v4l2-common.h:72:14: note: in expansion of macro 'KERN_ERR'
     v4l2_printk(KERN_ERR, dev, fmt , ## arg)
                 ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:769:3: note: in expansion of macro 'v4l2_err'
      v4l2_err(&dev->v4l2_dev,
      ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:770:66: note: format string is defined here
        "invalid tail (0x%x): must be smaller than mailbox size (0x%lx)\n",
                                                                   ~~^
                                                                   %x
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
   drivers/staging/media/allegro-dvt/allegro-core.c: In function 'allegro_mbox_read':
>> include/linux/kern_levels.h:5:18: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/media/v4l2-common.h:72:14: note: in expansion of macro 'KERN_ERR'
     v4l2_printk(KERN_ERR, dev, fmt , ## arg)
                 ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:798:3: note: in expansion of macro 'v4l2_err'
      v4l2_err(&dev->v4l2_dev,
      ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:799:66: note: format string is defined here
        "invalid head (0x%x): must be smaller than mailbox size (0x%lx)\n",
                                                                   ~~^
                                                                   %x
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
>> include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/media/v4l2-common.h:72:14: note: in expansion of macro 'KERN_ERR'
     v4l2_printk(KERN_ERR, dev, fmt , ## arg)
                 ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:810:3: note: in expansion of macro 'v4l2_err'
      v4l2_err(&dev->v4l2_dev,
      ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:811:32: note: format string is defined here
        "invalid message length: %lu bytes (maximum %lu bytes)\n",
                                 ~~^
                                 %u
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
   include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/media/v4l2-common.h:72:14: note: in expansion of macro 'KERN_ERR'
     v4l2_printk(KERN_ERR, dev, fmt , ## arg)
                 ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:810:3: note: in expansion of macro 'v4l2_err'
      v4l2_err(&dev->v4l2_dev,
      ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:811:51: note: format string is defined here
        "invalid message length: %lu bytes (maximum %lu bytes)\n",
                                                    ~~^
                                                    %u
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
   include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/media/v4l2-common.h:72:14: note: in expansion of macro 'KERN_ERR'
     v4l2_printk(KERN_ERR, dev, fmt , ## arg)
                 ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:816:3: note: in expansion of macro 'v4l2_err'
      v4l2_err(&dev->v4l2_dev,
      ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:817:38: note: format string is defined here
        "destination buffer too small: %lu bytes (need %lu bytes)\n",
                                       ~~^
                                       %u
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
>> include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'ssize_t' {aka 'int'} [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/media/v4l2-common.h:72:14: note: in expansion of macro 'KERN_ERR'
     v4l2_printk(KERN_ERR, dev, fmt , ## arg)
                 ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:816:3: note: in expansion of macro 'v4l2_err'
      v4l2_err(&dev->v4l2_dev,
      ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:817:54: note: format string is defined here
        "destination buffer too small: %lu bytes (need %lu bytes)\n",
                                                       ~~^
                                                       %u
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
   drivers/staging/media/allegro-dvt/allegro-core.c: In function 'allegro_receive_message':
>> include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'ssize_t' {aka 'int'} [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/media/v4l2-common.h:72:14: note: in expansion of macro 'KERN_ERR'
     v4l2_printk(KERN_ERR, dev, fmt , ## arg)
                 ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:1542:3: note: in expansion of macro 'v4l2_err'
      v4l2_err(&dev->v4l2_dev,
      ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:1543:30: note: format string is defined here
        "invalid mbox message (%ld): must be at least %lu\n",
                               ~~^
                               %d
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
   include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/media/v4l2-common.h:72:14: note: in expansion of macro 'KERN_ERR'
     v4l2_printk(KERN_ERR, dev, fmt , ## arg)
                 ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:1542:3: note: in expansion of macro 'v4l2_err'
      v4l2_err(&dev->v4l2_dev,
      ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:1543:53: note: format string is defined here
        "invalid mbox message (%ld): must be at least %lu\n",
                                                      ~~^
                                                      %u
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
   drivers/staging/media/allegro-dvt/allegro-core.c: In function 'allegro_copy_firmware':
   include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH'
    #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
                       ^~~~~~~~
   include/media/v4l2-common.h:85:16: note: in expansion of macro 'KERN_DEBUG'
       v4l2_printk(KERN_DEBUG, dev, fmt , ## arg); \
                   ^~~~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:1618:2: note: in expansion of macro 'v4l2_dbg'
     v4l2_dbg(1, debug, &dev->v4l2_dev,
     ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:1619:25: note: format string is defined here
      "copy mcu firmware (%lu B) to SRAM\n", size);
                          ~~^
                          %u
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
   drivers/staging/media/allegro-dvt/allegro-core.c: In function 'allegro_copy_fw_codec':
   include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^~~~~~~~
   include/media/v4l2-common.h:72:14: note: in expansion of macro 'KERN_ERR'
     v4l2_printk(KERN_ERR, dev, fmt , ## arg)
                 ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:1640:3: note: in expansion of macro 'v4l2_err'
      v4l2_err(&dev->v4l2_dev,
      ^~~~~~~~
   drivers/staging/media/allegro-dvt/allegro-core.c:1641:27: note: format string is defined here
        "failed to allocate %lu bytes for firmware\n", size);
                            ~~^
                            %u
   In file included from include/media/v4l2-subdev.h:24,
                    from include/media/v4l2-device.h:25,
                    from drivers/staging/media/allegro-dvt/allegro-core.c:22:
   include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^~~~~~
   include/media/v4l2-common.h:69:9: note: in definition of macro 'v4l2_printk'
     printk(level "%s: " fmt, (dev)->name , ## arg)
            ^~~~~
   include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH'
    #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
                       ^~~~~~~~
   include/media/v4l2-common.h:85:16: note: in expansion of macro 'KERN_DEBUG'
       v4l2_printk(KERN_DEBUG, dev, fmt , ## arg); \
..

vim +5 include/linux/kern_levels.h

314ba352 Joe Perches 2012-07-30  4  
04d2c8c8 Joe Perches 2012-07-30 @5  #define KERN_SOH	"\001"		/* ASCII Start Of Header */
04d2c8c8 Joe Perches 2012-07-30  6  #define KERN_SOH_ASCII	'\001'
04d2c8c8 Joe Perches 2012-07-30  7  

:::::: The code at line 5 was first introduced by commit
:::::: 04d2c8c83d0e3ac5f78aeede51babb3236200112 printk: convert the format for KERN_<LEVEL> to a 2 byte pattern

:::::: TO: Joe Perches <joe@xxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux