On Wed, 13 Feb 2019, Guenter Roeck wrote: > On 2/13/19 5:37 AM, Matti Vaittinen wrote: > > Initial support for watchdog block included in ROHM BD70528 > > power management IC. > > > > Configurations for low power states are still to be checked. > > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> > > Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > --- > > > > I maintained the ack from Guenter as only change is to use function > > exported by MFD instead of pointer to function provided by MFD. Please > > let me know if this is not Ok. > > > > NP. With functions exported by MFD, my choice would have been to handle > locking there as well with respective locking/unlocking functions exported. > But that is your call to make, not mine. FWIW, I agree. [...] Lots of superfluous quoting here mate. Better to snip it off IMHO. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
