On Mon, Feb 11, 2019 at 03:34:23PM +0000, Marc Zyngier wrote: > On 31/01/2019 08:03, Aisheng Dong wrote: > > One irqsteer channel can support up to 8 output interrupts. > > > > Cc: Marc Zyngier <marc.zyngier@xxxxxxx> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > > Cc: devicetree@xxxxxxxxxxxxxxx > > Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx> > > --- > > ChangeLog: > > v2->v3: > > * fix a typo > > v1->v2: > > * remove one unnecessary note. > > --- > > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > > index 6d0a41b..582991c 100644 > > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > > @@ -6,8 +6,9 @@ Required properties: > > - "fsl,imx8m-irqsteer" > > - "fsl,imx-irqsteer" > > - reg: Physical base address and size of registers. > > -- interrupts: Should contain the parent interrupt line used to multiplex the > > - input interrupts. > > +- interrupts: Should contain the up to 8 parent interrupt lines used to > > + multiplex the input interrupts. They should be specified sequentially > > + from output 0 to 7. > > - clocks: Should contain one clock for entry in clock-names > > see Documentation/devicetree/bindings/clock/clock-bindings.txt > > - clock-names: > > > > I'd like an Ack from a DT person, as this is a change to an existing > binding. It's fine as long as old kernels ignore extra entries and new kernels still support a single entry. Otherwise, it needs a explanation. Rob