On Tue, Feb 12, 2019 at 03:18:46PM -0600, Rob Herring wrote: > On Mon, Feb 11, 2019 at 3:23 AM Johan Hovold <johan@xxxxxxxxxx> wrote: > > > > On Wed, Jan 30, 2019 at 09:50:16AM -0600, Rob Herring wrote: > > > On Mon, Jan 28, 2019 at 05:37:59PM +0100, Loys Ollivier wrote: > > > > Add binding for Mediatek-based GNSS receivers. > > > > > > > > Signed-off-by: Loys Ollivier <lollivier@xxxxxxxxxxxx> > > > > +- gtop,fix-gpios : GPIO used to determine device position fix state > > > > + (pin name: FIX, 3D_FIX) > > > > I'm thinking we might need a standard name for fix-gpios as well. This > > isn't a feature that is globaltop (or mediatek) specific, and other > > manufacturers provide similar functionality through pins named UI_FIX, > > or even LCKIND (lock indicator). > > > > The pin is typically used to drive an indicator LED AFAIU, but the > > characteristics of the signal varies from device to device (fw to fw), > > for example, pulse when no lock and low otherwise, or pulse when a 2d or > > 3d-fix is acquired, etc. > > > > I'm not sure how useful the pulsing would be for software, but someone > > might find a use for it in some form. > > > > Rob, is this something we want to keep in the binding, and if so, how > > about using a generic name such as "gnss-fix-gpios"? > > Sure. As long as details like being a pulse and when the pulse occurs > are implied by compatible string. So we don't get an endless addition > of properties to describe those. Agreed, thanks. Johan
