Hello Linus, On Fri, 11 Jan 2019 11:14:49 +0100 Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > This commit adds a minimal implementation of the ->set_config() hook, > > with support for the PIN_CONFIG_BIAS_PULL_UP and > > PIN_CONFIG_BIAS_PULL_DOWN configurations. > > > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> > > This looks OK to me, but IIUC not all versions of the PCA953x supports > this? > > So we need to make sure that you return -ENOTSUPP if the device > does not support setting pull up/down. Indeed, I've added a check for this. > Also there are configs for debounce too, right? I suggested to add > that first but I have no strong opinion on it. The particular PCA variant that I have does not have any debounce related capability it seems, so I won't be able to implement this aspect. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
