On Thu, Jan 3, 2019 at 5:41 PM Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> wrote: > This commit adds a minimal implementation of the ->set_config() hook, > with support for the PIN_CONFIG_BIAS_PULL_UP and > PIN_CONFIG_BIAS_PULL_DOWN configurations. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> This looks OK to me, but IIUC not all versions of the PCA953x supports this? So we need to make sure that you return -ENOTSUPP if the device does not support setting pull up/down. Also there are configs for debounce too, right? I suggested to add that first but I have no strong opinion on it. Yours, Linus Walleij
