Hello Russell, On Wed, 06 Feb 2019 11:35:07 +0000 Russell King <rmk+kernel@xxxxxxxxxxxxxxx> wrote: >+ if (pp->comphy) { >+ enum phy_mode mode = PHY_MODE_INVALID; >+ >+ switch (state->interface) { >+ case PHY_INTERFACE_MODE_SGMII: >+ case PHY_INTERFACE_MODE_1000BASEX: >+ mode = PHY_MODE_SGMII; PHY_MODE_SGMII no longer exists, the new PHY_MODE_ETHERNET must be used with the correct submode now, so this doesn't build unfortunately. >+ break; >+ case PHY_INTERFACE_MODE_2500BASEX: >+ mode = PHY_MODE_2500SGMII; Same here. Thanks, Maxime