On Sat, Feb 2, 2019 at 7:59 PM Martin Kelly <martin@xxxxxxxxxxxxxxxx> wrote: > > From: Martin Kelly <martin@xxxxxxxxxxxxxxxx> > > We are using "if (ret < 0)" in many places in which the function returns 0 > on success. Use "if (ret)" instead for better clarity and correctness. What's wrong with "if (ret < 0)" ?