Hi Sudeep, > -----Original Message----- > From: Sudeep Holla <sudeep.holla@xxxxxxx> > Sent: Friday, February 01, 2019 4:15 AM > To: Jolly Shah <JOLLYS@xxxxxxxxxx> > Cc: matthias.bgg@xxxxxxxxx; andy.gross@xxxxxxxxxx; shawnguo@xxxxxxxxxx; > geert+renesas@xxxxxxxxx; bjorn.andersson@xxxxxxxxxx; > sean.wang@xxxxxxxxxxxx; m.szyprowski@xxxxxxxxxxx; Michal Simek > <michals@xxxxxxxxxx>; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; Rajan > Vaja <RAJANV@xxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v6 3/3] drivers: soc: xilinx: Add ZynqMP PM driver > > On Thu, Jan 31, 2019 at 07:01:05PM +0000, Jolly Shah wrote: > > > > > > NACK, if this is for system suspend/reset ? You can just use exiting > > > sysfs, no need to create Xilinx specific new ones. Moreover you need to > > > use PSCI to make sure higher ELs can do orderly suspend/shutdown. > > > > > > > We have power off suspend mode which is not supported by existing sysfs and > > hence new one is needed. Suspend is handled through PSCI interface only. > > > > I see only 2 cases supported SUSPEND_SYSTEM_SHUTDOWN and > SUSPEND_POWER_REQUEST. Both are already support so my NACK still stands. The 2 cases(SUSPEND_SYSTEM_SHUTDOWN and SUSPEND_POWER_REQUEST )in isr is for remote suspend. Sysfs is for self suspend and it supports PM_SUSPEND_MODE_STD and PM_SUSPEND_MODE_POWER_OFF(power off suspend). Thanks, Jolly Shah > > -- > Regards, > Sudeep
