On 28/01/2019 19:04, Russell King - ARM Linux admin wrote:
Hi Russell,
There is no "advertisement of SmartEEE" - it's just EEE. That is
because as far as the link partner is concerned, SmartEEE is just
EEE.
Carlio posted a link to one of the datasheets for the family. In
there, it describes the EEE capability register, which describes
what is supported, and the EEE wake error counter register.
It also describes the EEE advertisement and link parter advertisement
registers.
All these registers correspond to the 802.3 section 45 defined MMD
and address offsets found in Clause 45 compliant PHYs, and these
registers control not only EEE but also SmartEEE.
Please stop thinking that SmartEEE is different on the link partner
side from EEE - as far as the link partner is concerned, there is
no difference. The difference is all to do with the MAC side of
the local PHY.
Thank you for clarifying how the SmartEEE is really working.
Now, the problem is that the MMD registers controlling the EEE (7.3c and
7.3d, touched by the "eee-broken-*" property) are not the same as the
ones for the SmartEEE (3.805b, 3.805c, 3.805d). So, is it worth to add a
new DT property to deal also with the cases where we want to selectively
disable the SmartEEE?
Thanks,
--
Carlo Caione
