Hi, Bibby: On Tue, 2019-01-29 at 15:31 +0800, Bibby Hsieh wrote: > add mt8183 compatible name > > Signed-off-by: Bibby Hsieh <bibby.hsieh@xxxxxxxxxxxx> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index 2281178..909eb23 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -536,6 +536,7 @@ static int cmdq_probe(struct platform_device *pdev) > > static const struct of_device_id cmdq_of_ids[] = { > {.compatible = "mediatek,mt8173-gce", .data = (void *)16}, > + {.compatible = "mediatek,mt8183-gce", .data = (void *)24}, You should define it then use it, so reorder this patch after the binding patch. Regards, CK > {} > }; >